fix: Consider the presence of converters when checking if attributes can be bound to the type#135
Merged
JackRobards merged 1 commit intomainfrom Jan 24, 2025
Conversation
🦋 Changeset detectedLatest commit: 63ee9f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JackRobards
force-pushed
the
consider-converters-in-attribute-binding
branch
from
3ea85bf to
bc574b8
Compare
…can be bound to the type
JackRobards
force-pushed
the
consider-converters-in-attribute-binding
branch
from
bc574b8 to
63ee9f6
Compare
Owner
Author
|
Reworked the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so if the attribute on a Lit component has a custom converter, then the plugin should not report errors related to it being passed an incompatible type. It is up to the converter to handle converting it from a string to the component type!
This change comes from the below PR from the runem repository (I just ported it over here). Thank you to the original author!
runem#126