Skip to content

ci: add strict type checking and resolve sysaudio path types #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacksonFergusonDev merged 2 commits into from
Jan 31, 2026
Merged

ci: add strict type checking and resolve sysaudio path types #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36bb423
feat(sysaudio): add robust signal I/O and metadata handling
JacksonFergusonDev Jan 31, 2026
49a281f
fix(sysaudio): allow Path objects in load_signal
JacksonFergusonDev Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ jobs:
uv run ruff check .
uv run ruff format --check .

- name: Type check with mypy
run: uv run mypy oscilloscope-rp2040

- name: Run Tests
run: uv run pytest

Expand Down
5 changes: 3 additions & 2 deletions oscilloscope-rp2040/sysaudio/io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
import os
import sys
from datetime import datetime
from typing import Any, Optional, Tuple
from pathlib import Path
from typing import Any, Optional, Tuple, Union

import numpy as np
import pandas as pd
Expand Down Expand Up @@ -63,7 +64,7 @@ def save_signal(
return path


def load_signal(filepath: str) -> Tuple[np.ndarray, float]:
def load_signal(filepath: Union[str, Path]) -> Tuple[np.ndarray, float]:
"""
Robust loader for .npz files.

Expand Down