Dashboard optimization#19
Merged
Merged
Conversation
…t this interface to promote loose coupling and allow for future iterations to more easily create other variations of the dashboard service.
…rvice to promote loose coupling.
…atic constants in the class for the recent activities, better variable names for these fetched values, and to refactor repeated code into methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
Update the dashboard to instead have a dhasboard service that is implemented by the service for the dashboard service implementation thus to promote loose coupling.
Update the dashboard controller to have static constants such that we should not repeat code in the dashboard controller for formatting.
Update the dashboard controller to have an inner static time formatter helper class such that easch class follows the Single Responsibility principle.
Relation To other Tickets
Related to #18 as this is the next modular optimization.