Employer/Employer Optimization and Fixes#20
Merged
Conversation
…odifiable list to allow for more easily readable and abstracted code.
…sses with author contributions.
…ication and abstract out error messages.
… not found execptiopns rather than generic runtime exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
Cleanup the documenation for all employer and employee related classes (controllers, services, dtos, and models).
Cleanup author docs.
Cleanup list conversions, moving away from collections invocations and towards a simple .toList()./
Cleanup ambiguous exceptions, in favor of more specific exception handling (EmloyerNotFoundException >> RuntimeException).
Slight deviation
Update the global exception handler to use an enumerated type for error messages to reduce code duplication and support abstraction (propmote DRY).