fix: cli template creates binpath without --binary flag#10
Open
Deepak8858 wants to merge 1 commit into
Open
Conversation
Owner
|
@Deepak8858 Thank you for participating in project! Sorry that it took me a long time to respond for your PR. Can you update your code for tests? Currently, not all tests are being run. You have an old version where the tests were configured for golang version 1.25.5. It was fixed in this commit. Merge main with your branch before updating your code. I also fixed workflows. After sending PR I can check your tests. If they pass, I will merge your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
gowncli templatewould generate code containingbinpathandbinInfoeven when the--binaryflag was not provided.Changes:
HasBinaryfield toTemplateParams.BinPathandHasBinaryinNewTemplateCmd.main.go.tmplto useHasBinaryfor conditional code generation.Fixes #9