Skip to content

add support for reading arguments from config files #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayvazjmm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add support for reading arguments from config files #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,13 @@ To include `adb` and other android tools on your path:

Include these lines in your `.bashrc` or `.zshrc`.

CONFIGURATION
-------------

Arguments can be specified at the command line or in one of the following config files: ~/.pidcat.conf or ./.pidcat.conf

cat ~/.pidcat.conf
--min-level=D


[1]: http://jsharkey.org/blog/2009/04/22/modifying-the-android-logcat-stream-for-full-color-debugging/
Expand Down
9 changes: 7 additions & 2 deletions pidcat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,18 @@
# Package filtering and output improvements by Jake Wharton, http://jakewharton.com

import argparse
import os
import sys
import re
import subprocess
from subprocess import PIPE

__version__ = '2.0.0'

FROMFILE_PREFIX='@'
LOG_LEVELS = 'VDIWEF'
LOG_LEVELS_MAP = dict([(LOG_LEVELS[i], i) for i in range(len(LOG_LEVELS))])
parser = argparse.ArgumentParser(description='Filter logcat by package name')
parser = argparse.ArgumentParser(description='Filter logcat by package name', fromfile_prefix_chars=FROMFILE_PREFIX)
parser.add_argument('package', nargs='*', help='Application package name(s)')
parser.add_argument('-w', '--tag-width', metavar='N', dest='tag_width', type=int, default=23, help='Width of log tag')
parser.add_argument('-l', '--min-level', dest='min_level', type=str, choices=LOG_LEVELS+LOG_LEVELS.lower(), default='V', help='Minimum level to be displayed')
Expand All @@ -46,7 +48,10 @@
parser.add_argument('-i', '--ignore-tag', dest='ignored_tag', action='append', help='Filter output by ignoring specified tag(s)')
parser.add_argument('-v', '--version', action='version', version='%(prog)s ' + __version__, help='Print the version number and exit')

args = parser.parse_args()
CONF_FILES = [ os.path.expanduser('~/.pidcat.conf'), './.pidcat.conf' ]
argv = [ '%s%s' % (FROMFILE_PREFIX, conf) for conf in CONF_FILES if os.path.isfile(conf) ]
argv.extend(sys.argv[1:])
args = parser.parse_args(argv)
min_level = LOG_LEVELS_MAP[args.min_level.upper()]

package = args.package
Expand Down