Conversation
Jakeler
requested changes
Apr 11, 2020
| if source != '': | ||
| source_filename=os.path.basename(source) | ||
| destination=args.target + "/" + source_filename | ||
| print("Copying " + source + " to " + destination) |
Owner
There was a problem hiding this comment.
Please use logging instead of print. Level info would be suitable here
| if reply[0] == 'n': | ||
| return False | ||
| else: | ||
| return yes_or_no("Please enter y or n:") |
Owner
There was a problem hiding this comment.
It crashes if you hit just enter:
Traceback (most recent call last):
File "adb-root.py", line 92, in <module>
pull()
File "adb-root.py", line 74, in pull
if yes_or_no("Destination file exits. Ovewrite it ?"):
File "adb-root.py", line 57, in yes_or_no
if reply[0] == 'y':
IndexError: string index out of range
Would be better to just default to no (y/N) if the input is empty here.
Owner
|
Thanks, that works. Note that it still does not handle subdirectories and creates empty files. btw: You can add more commits by pushing on your fork/branch, you don't have to make a new pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let pull files with wildcards. dst-filename=src-filename always. Destination must be always a directory.