feat: remove the share specified by the user in addition to deleting the folder#1
Open
kernel-sanders wants to merge 1 commit into
Open
feat: remove the share specified by the user in addition to deleting the folder#1kernel-sanders wants to merge 1 commit into
kernel-sanders wants to merge 1 commit into
Conversation
…the folder when calling sharefolder_delete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
sharefolder_deletea user will likely assume that the share created withsharefolder_createis removed from the target system. This is not the case, only the folder is deleted and the share remains active. This merge fixes that oversight and removes both the folder and the share from the target usingNetShareDel.