feat(icon): update jamf CLI icon image

[neilmartin83]

Icon was kindly created and supplied by @mvdbent

If this is approved, we should roll it into the Concepts website page for jamf-cli and anywhere else the old one is used too.

[ktn-jamf]

🤖 Automated review of commit b715306 — verdict: APPROVE

Tip

Merge-ready -- Replaces the jamf-cli site icon (docs/site/img/jamf-cli-icon.png) with an updated design contributed by @mvdbent. No functional code changes; CI passes.

CI Status: ci pass, preflight pass.

Prior reviews: No prior reviews or comments.

Risk level: Low -- single binary asset swap, no source code changes, no dependency changes.

Diff scope: 1 file changed (docs/site/img/jamf-cli-icon.png) -- binary image replacement.

Analysis:

The old icon is ~7.9 KB; the new icon is ~124.7 KB (roughly 16x larger). The icon is rendered in CSS at fixed dimensions (height: 64px in the hero, height: 24px in the nav, with smaller breakpoints), so the larger file provides significantly more detail than needed at those display sizes. This is not blocking -- it is a PNG icon, not a photograph, and ~125 KB is well within acceptable limits for a site asset that loads once. But it is worth noting as a nice-to-have optimization opportunity.

The icon is referenced in exactly two places in docs/site/index.html:

1. Nav brand: <img src="img/jamf-cli-icon.png" alt="" class="nav-icon">
2. Hero: <img src="img/jamf-cli-icon.png" alt="jamf-cli" class="hero-icon">

No other files in the repository reference this image. The favicon.svg and jamf-icon.svg are separate assets and are not affected.

Nice-to-have suggestions (1 item)

🟩 (1) (performance) -- docs/site/img/jamf-cli-icon.png: Image is 16x larger than the original

The new icon is ~125 KB vs the old ~8 KB. At maximum display size of 64x64 CSS pixels (128x128 at 2x retina), a PNG this large likely contains resolution far beyond what is rendered. This adds ~117 KB to initial page load for no visible benefit.

Suggested fix: Run the image through a PNG optimizer (e.g., pngquant, optipng, or Squoosh) targeting a reasonable resolution for the display sizes used (256x256 would be generous for 2x retina at 64px display). Alternatively, consider converting to SVG if the icon design supports it, which would match the favicon approach already used in this repo.

Fixed when: The icon file is under ~30 KB without visible quality loss at 64px display size, or the team has consciously decided the current size is acceptable.

Review coverage

• Design and architecture: Single asset swap, filename preserved so all references work without code changes. Clean approach.
• Correctness: Verified the filename is identical (jamf-cli-icon.png), so both index.html references resolve correctly. No broken paths.
• Security: Binary image file, no executable content or metadata concerns.
• [na] Performance: Flagged file size increase as nice-to-have above. Not blocking.
• [na] Test coverage: No testable code changes.
• [na] Reliability: Asset-only change.
• [na] Code quality: No code changes.
• [na] Simplification: N/A.
• [na] Frontend concerns: Display dimensions are CSS-constrained; the larger image will render identically. No layout or accessibility impact (alt text unchanged).

What's done well

The approach of replacing the file in-place (same filename, same path) means zero code changes required -- all existing references just work. The PR description also notes the broader rollout needed (Concepts website), which shows good awareness of downstream consumers.

Generated with Claude Code