feat(classic): add advanced mobile device searches commands#213
Conversation
Adds classic-advanced-mobile-device-searches (list, get, create, update, delete, apply) via the classic spec generator. Mirrors the existing classic-advanced-computer-searches pattern. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ktn-jamf
left a comment
There was a problem hiding this comment.
✅ Merge-ready
Small, mechanical, convention-following addition. Drops one resource into specs/classic/resources.yaml, wires the new generated command into groups.go, regenerates. All hand-touched lines are minimal and correct; all 503 lines in classic_advanced_mobile_device_searches.go are templated output and structurally identical to classic_advanced_computer_searches.go. CI green. make verify-generated clean.
What it does
Issue #212 reports that pro advanced-mobile-device-searches get <id> (Modern API) returns only the search definition, not the matching mobile devices. The Modern API endpoint genuinely doesn't return device results — server-side gap, not a CLI bug. The Classic API endpoint /JSSResource/advancedmobiledevicesearches/id/{id} does return device results, so the PR exposes that as a parallel command. This mirrors the existing classic-advanced-computer-searches precedent and is the right fix path for this repo.
💡 Nice-to-have — discovery breadcrumb
Users who hit the issue will run pro advanced-mobile-device-searches get …, see no devices, and have no in-product hint that pro classic-advanced-mobile-device-searches get … returns the data they want. Closing #212 with a parallel command works, but the original entry point doesn't signpost the workaround. Optional fix: mention it in the PR description or a docs/solutions/ note. Not blocking.
Summary
classic-advanced-mobile-device-searchesto the Classic API spec (specs/classic/resources.yaml)list,get,create,update,delete,applygroupClassicMobileingroups.goCloses #212
Test plan
make generate && make test— all passpro classic-advanced-mobile-device-searches list— returns 14 results on pro-nmartinpro classic-advanced-mobile-device-searches get --name "Failed Enrolments"— returns full record with criteria and device resultspro-nmartinandplatform-nmartinprofiles verified🤖 Generated with Claude Code