Skip to content

feat(classic): add advanced mobile device searches commands#213

Merged
neilmartin83 merged 1 commit into
mainfrom
feat/classic-advanced-mobile-device-searches
May 18, 2026
Merged

feat(classic): add advanced mobile device searches commands#213
neilmartin83 merged 1 commit into
mainfrom
feat/classic-advanced-mobile-device-searches

Conversation

@neilmartin83
Copy link
Copy Markdown
Member

Summary

  • Adds classic-advanced-mobile-device-searches to the Classic API spec (specs/classic/resources.yaml)
  • Regenerates commands: list, get, create, update, delete, apply
  • Wires into groupClassicMobile in groups.go

Closes #212

Test plan

  • make generate && make test — all pass
  • pro classic-advanced-mobile-device-searches list — returns 14 results on pro-nmartin
  • pro classic-advanced-mobile-device-searches get --name "Failed Enrolments" — returns full record with criteria and device results
  • Both pro-nmartin and platform-nmartin profiles verified

🤖 Generated with Claude Code

Adds classic-advanced-mobile-device-searches (list, get, create, update,
delete, apply) via the classic spec generator. Mirrors the existing
classic-advanced-computer-searches pattern.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@ktn-jamf ktn-jamf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Merge-ready

Small, mechanical, convention-following addition. Drops one resource into specs/classic/resources.yaml, wires the new generated command into groups.go, regenerates. All hand-touched lines are minimal and correct; all 503 lines in classic_advanced_mobile_device_searches.go are templated output and structurally identical to classic_advanced_computer_searches.go. CI green. make verify-generated clean.

What it does

Issue #212 reports that pro advanced-mobile-device-searches get <id> (Modern API) returns only the search definition, not the matching mobile devices. The Modern API endpoint genuinely doesn't return device results — server-side gap, not a CLI bug. The Classic API endpoint /JSSResource/advancedmobiledevicesearches/id/{id} does return device results, so the PR exposes that as a parallel command. This mirrors the existing classic-advanced-computer-searches precedent and is the right fix path for this repo.

💡 Nice-to-have — discovery breadcrumb

Users who hit the issue will run pro advanced-mobile-device-searches get …, see no devices, and have no in-product hint that pro classic-advanced-mobile-device-searches get … returns the data they want. Closing #212 with a parallel command works, but the original entry point doesn't signpost the workaround. Optional fix: mention it in the PR description or a docs/solutions/ note. Not blocking.

@neilmartin83 neilmartin83 merged commit 0d0ae00 into main May 18, 2026
2 checks passed
@neilmartin83 neilmartin83 deleted the feat/classic-advanced-mobile-device-searches branch May 18, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jamf-cli pro advanced-mobile-device-searches get <id> doesn't contains the matching mobile devices

2 participants