feat(expect): added null as positive value for toBeOptionalOf#54
Open
npwork wants to merge 1 commit intoJamieMason:masterfrom
Open
feat(expect): added null as positive value for toBeOptionalOf#54npwork wants to merge 1 commit intoJamieMason:masterfrom
npwork wants to merge 1 commit intoJamieMason:masterfrom
Conversation
Owner
|
Thanks a lot, on my mobile just now but what I would want to do is instead put this behaviour in a new matcher called toBeNilOf, and maybe also add a toBeNullable of. This is just so it doesn't surprise anyone - although null means "nothing" it is still the presence of a value (even if that value describes nothing) - whereas undefined is the absence of a value. Really hope that makes sense 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (What)
It would be nice to have
nullas a positive value(as well asundefined) fortoBeOptionalOfJustification (Why)
There are cases when object received from server (dto) has null as a value. In this case
toBeOptionalOffails which not correct. It should treatnullthe same way asundefinedHow Can This Be Tested?