Add CI/CD workflows and modern packaging from PR #33#42
Add CI/CD workflows and modern packaging from PR #33#42JanStreffing merged 19 commits intomasterfrom
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
I was not yet able to get the import test to work, since the package has dependencies that don't work in pip. This would require pixi to work. Which it did not for me. |
|
Ok it works now. |
- Switch from CDO-based to polygon method for land-sea mask (from master) - Add pyfesom2 mesh.nc generation when file missing or force_overwrite=true - Fix masked array handling for cav_nod_mask in CORE3 - Update run_ocp_tool.py to use read_fesom_grid_polygon
The cavity support and bug fix are now in main, no need for the old feat/ascii_to_netcdf_with_cavity branch.
…iles for each config
|
This version is not yet working for me since the output folder structure is not created on the fly. The code fails with the error: The code expects an output folder which is named after the mesh setup, in my case I fixed this with an additional function which initially creates the respective output folders in https://github.com/JanStreffing/ocp-tool/compare/bugfix/output_directories, it now works like a charm. If you are fine with this @JanStreffing, I would close this PR and open a new one which includes my fix. |
|
I merged your branch into this, and then into master. |
3 participants
Superseeds #33