Skip to content
This repository was archived by the owner on Mar 18, 2026. It is now read-only.

Feature/graph#12

Merged
simonott1 merged 33 commits intomainfrom
feature/graph
Jun 3, 2025
Merged

Feature/graph#12
simonott1 merged 33 commits intomainfrom
feature/graph

Conversation

@simonott1
Copy link
Copy Markdown
Collaborator

No description provided.

@simonott1 simonott1 requested a review from Matti3939 May 28, 2025 09:13
@simonott1 simonott1 self-assigned this May 28, 2025
Copy link
Copy Markdown
Collaborator

@Matti3939 Matti3939 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general points

  • remove the .vite/** artifacts
  • add some screenshots to the cypress tests
  • cypress should cover all functional requirements which includes the loadingtime of the graph
  • fix code styling (cypress/e2e/graph/graphView.cy.ts has many blanks lines in between, some files have weird indentations etc, check them all please)
  • merge main so we can also see it with dark mode enabled
  • run a system test at the end and link it in the pr description

When you just have sep2 in you plan an then open the graph, add first sep1 and then seproj. All modules get added to the same semester. Maybe check in which semester they can be visited before inserting?

@simonott1
Copy link
Copy Markdown
Collaborator Author

Link to the system test:
https://github.com/Janooski/web/actions/runs/15377674939

Copy link
Copy Markdown
Collaborator

@Matti3939 Matti3939 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • cypress run screenshots look very funny, please check them.
  • I don't find the screenshot names clear. One says "graph view enabled" but there is no graph and another says "graph view disabled" but there is a graph? You might need to resize the screen (and or move the graph) to capture the whole graph
  • The graph does not show up at all on mobile
  • The navbar is unusable if you are using an iPad or smaller device
  • when you open the graph and there is no module in the plan, it still shows the last module(s)

@simonott1
Copy link
Copy Markdown
Collaborator Author

Here the current System Test:
https://github.com/Janooski/web/actions/runs/15404272272

@simonott1
Copy link
Copy Markdown
Collaborator Author

The new system passes, after merging main into this branch:
https://github.com/Janooski/web/actions/runs/15421118867

@simonott1 simonott1 merged commit 0dfaf84 into main Jun 3, 2025
10 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants