This repository was archived by the owner on Mar 18, 2026. It is now read-only.
Merged
Conversation
Matti3939
suggested changes
May 29, 2025
Collaborator
There was a problem hiding this comment.
Some general points
- remove the .vite/** artifacts
- add some screenshots to the cypress tests
- cypress should cover all functional requirements which includes the loadingtime of the graph
- fix code styling (cypress/e2e/graph/graphView.cy.ts has many blanks lines in between, some files have weird indentations etc, check them all please)
- merge main so we can also see it with dark mode enabled
- run a system test at the end and link it in the pr description
When you just have sep2 in you plan an then open the graph, add first sep1 and then seproj. All modules get added to the same semester. Maybe check in which semester they can be visited before inserting?
Collaborator
Author
|
Link to the system test: |
Matti3939
suggested changes
Jun 2, 2025
Collaborator
There was a problem hiding this comment.
- cypress run screenshots look very funny, please check them.
- I don't find the screenshot names clear. One says "graph view enabled" but there is no graph and another says "graph view disabled" but there is a graph? You might need to resize the screen (and or move the graph) to capture the whole graph
- The graph does not show up at all on mobile
- The navbar is unusable if you are using an iPad or smaller device
- when you open the graph and there is no module in the plan, it still shows the last module(s)
Collaborator
Author
|
Here the current System Test: |
Collaborator
Author
|
The new system passes, after merging main into this branch: |
Matti3939
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.