feat: GM toggle to disable individual Edge actions (#863)#896
Merged
Conversation
Wire the existing `disabledEdgeActionIds` house rule into the rule engine and UI: - `canUseEdgeAction` now rejects actions listed in `context.disabledActionIds` with a clear GM-disabled reason. - `EdgeActionSelector` accepts `disabledActionIds` and hides disabled buttons (returning null when every action for the timing is disabled). - `HouseRulesForm` renders per-action checkboxes for the six SR5 Edge actions (Push the Limit, Second Chance, Seize the Initiative, Blitz, Close Call, Dead Man's Trigger), replacing the "not yet editable" placeholder. - Add tests covering the disabled-action branch in both the rule engine and the selector component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disabledEdgeActionIdshouse rule intocanUseEdgeActionso disabled actions are rejected with a GM-disabled reason.EdgeActionSelectornow acceptsdisabledActionIdsand hides disabled buttons (returns null when every action for the timing is disabled).HouseRulesFormwith per-action checkboxes for the six SR5 Edge actions (Push the Limit, Second Chance, Seize the Initiative, Blitz, Close Call, Dead Man's Trigger).Closes #863.
Test plan
pnpm test— 505 files / 10524 tests passpnpm type-check— cleanedge-actions.test.tscovering the disabled-by-GM branch and an empty disabled listEdgeActionSelector.test.tsxcovering per-timing hiding and the fully-disabled-null render