feat: wire hit threshold and glitch rules into dice engine (#846)#897
Merged
Conversation
Add resolveDiceRules() helper that applies HouseRules overrides (hitThreshold, glitchThreshold, woundBoxesPerPenalty, woundMaxPenalty) to EditionDiceRules. Wire campaign house rules through the action executor and three action/reroll/combat API routes so GM toggles actually affect rolls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #846.
resolveDiceRules(houseRules, base)inlib/rules/action-resolution/dice-engine.tsthat mergeshitThreshold,glitchThreshold,woundBoxesPerPenalty, andwoundMaxPenaltyoverrides onto anEditionDiceRulesbase (other fields preserved).houseRulesthroughExecutionRequest/RerollRequestso the action executor resolves campaign-specific dice rules before rolling.characters/[id]/actions, its reroll endpoint, andcombat/[sessionId]/actions) so the GM toggles already in the settings UI actually affect rolls. Campaign is looked up viacharacter.campaignId/session.campaignId.Test plan
pnpm type-checkpnpm test— 10536 passedpnpm eslinton changed files — no new warningsresolveDiceRulescovering undefined/empty input, single + combined threshold overrides, wound modifier overrides (including sign normalization), base preservation, and integration withcalculateHits/calculateGlitch.