This repository was archived by the owner on Mar 9, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(granc-core): add dynamic_stream() for true streaming support #59
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| use futures_util::stream::BoxStream; | ||
| use prost_reflect::{EnumDescriptor, MessageDescriptor, ServiceDescriptor}; | ||
| use std::fmt::Debug; | ||
|
|
||
|
|
@@ -25,6 +26,18 @@ pub enum DynamicResponse { | |
| Streaming(Result<Vec<Result<serde_json::Value, tonic::Status>>, tonic::Status>), | ||
| } | ||
|
|
||
| /// The result of a dynamic gRPC call that preserves streaming semantics. | ||
| /// | ||
| /// Unlike [`DynamicResponse`], which collects all streaming messages into a `Vec`, | ||
| /// this type returns a [`BoxStream`] for streaming RPCs, allowing the caller to | ||
| /// consume messages incrementally as they arrive. | ||
| pub enum DynamicStreamResponse { | ||
| /// A single response message (for Unary and Client Streaming calls). | ||
| Single(Result<serde_json::Value, tonic::Status>), | ||
| /// A stream of response messages (for Server Streaming and Bidirectional calls). | ||
| Streaming(BoxStream<'static, Result<serde_json::Value, tonic::Status>>), | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe there is no need for a new type here, we can simply update the implementation of 'dynamic' and update the original DynamicResponse::Stream to use a BoxStream This way we have a consistent API with a single dynamic function Don't worry about breaking changes, we can always create a new breaking release (minor in this case since we are under version 0.X.X) |
||
| } | ||
|
|
||
| /// A generic wrapper for different types of Protobuf descriptors. | ||
| /// | ||
| /// This enum allows the client to return a single type when resolving symbols, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
honestly looking at the implementation, we can simply unify this into the 'dynamic' method