Skip to content

Bugfixes for timeframe splitting#479

Merged
nathanwbrei merged 14 commits into
masterfrom
nbrei_tf_fix
Nov 19, 2025
Merged

Bugfixes for timeframe splitting#479
nathanwbrei merged 14 commits into
masterfrom
nbrei_tf_fix

Conversation

@nathanwbrei
Copy link
Copy Markdown
Collaborator

@nathanwbrei nathanwbrei commented Nov 11, 2025

Most of these bugs were introduced during the JFactory refactoring, or the quick-and-dirty implementation of VariadicPodioOutput.

  • jana:wiring_file was prefixed twice (jana:jana:wiring_file)
  • VariadicPodioOutput<T> didn't support SetSubsetCollection()
  • VariadicPodioOutput<T> level was incorrectly defaulted (should have been None, so that can later default to the same level as the owning JComponent)
  • The PodioOutput constructor interpreted collection_name to be the short_name, not the unique_name
  • VariadicPodioOutput::EulerianStore didn't replace its "transient" collections after moving them into the podio Frame.
  • None of the EulerianStore() implementations set the JFactory status, leading to JFactory::Create() attempting to re-create their contents.
  • JEventUnfolder::DoPreprocess() wasn't being called, leading to unfolder inputs being created inside UnfoldArrow instead of MapArrow.

@nathanwbrei nathanwbrei changed the title Nbrei tf fix Bugfixes for timeframe splitting Nov 19, 2025
@nathanwbrei nathanwbrei merged commit 4b467a0 into master Nov 19, 2025
15 of 18 checks passed
@nathanwbrei nathanwbrei deleted the nbrei_tf_fix branch November 19, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant