Conversation
tagger time calibration [rtj]
assignment of the tree file where beam currents are looked up [rtj]
|
Test status for this pull request: SUCCESS Summary: /work/halld/pull_request_test/halld_recon^PStagstudy_plugin_rtj/tests/summary.txt Build log: /work/halld/pull_request_test/halld_recon^PStagstudy_plugin_rtj/make_PStagstudy_plugin_rtj.log |
|
|
Hello Alex,
I looked through all of the plugins for the string "new TFile" and I don;t
find anything that looks like a good example. The one exception is
Analysis/photoneff_hists but there I don't find any actual trees being
defined to write into that root file. My worry is that, with the ROOT file
management monolith, by opening this ROOT file for writing, it will grab
other output from other plugins and/or core classes and screw up the ROOT
output structure. How can I be sure that the ROOT file I create and use for
my new TTree will be invisible to all other runtime components?
…-Richard Jones
On Mon, Feb 23, 2026 at 10:15 AM Alexander Austregesilo < ***@***.***> wrote:
*aaust* left a comment (JeffersonLab/halld_recon#1104)
<#1104 (comment)>
- The plugin writes a large tree into the histogram file. It should
create a separate output tree file instead. This can be handled with
DTreeInterface, see other plugins for examples
- The histograms should be placed in a folder with the plugin name.
This makes it easier to identify which plugin fills which histograms in a
production with many plugins.
—
Reply to this email directly, view it on GitHub
<#1104 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3YKWEJRWV6YNZPEG5XVIT4NMKQ5AVCNFSM6AAAAACV4YSH3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNBVGM2TCNRZHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I started working on it, only partially done |
|
@rjones30 I replaced the filling of all scalars and 1d arrays with the methods from DTreeInterface. I tried to keep all branch names and types the same, but it is easy to introduce typos. Could you please check if the trees are compatible with your analysis code? Unfortunately, there is not an easy way to save the raw waveforms as |
… if the reported pulse number is 1
…ing, but clear the GTP trigger bits from affected events and also generate BadHits
compile with either c++17 or c++20. [rtj]
the xstream library is now provided by the HDDM package. [rtj]
|
Test status for this pull request: SUCCESS Summary: /work/halld/pull_request_test/halld_recon^PStagstudy_plugin_rtj/tests/summary.txt Build log: /work/halld/pull_request_test/halld_recon^PStagstudy_plugin_rtj/make_PStagstudy_plugin_rtj.log |
missing tree fills
src/plugins/Calibration/PStagstudy/JEventProcessor_PStagstudy.cc
Outdated
Show resolved
Hide resolved
|
Test status for this pull request: SUCCESS Summary: /work/halld/pull_request_test/halld_recon^PStagstudy_plugin_rtj/tests/summary.txt Build log: /work/halld/pull_request_test/halld_recon^PStagstudy_plugin_rtj/make_PStagstudy_plugin_rtj.log |
5 participants
No description provided.