Open
Conversation
…ate into vertical settings feat(downloads): implement functions to clear and cancel pending downloads in downloads store
…r, Privacy, Storage, and Playback - Implemented AboutSection to display app information, patrons, and links to report issues and join Discord. - Created AppearanceSection for theme selection and runtime visibility settings. - Added GesturesSection to configure swipe actions for tracks. - Developed DeveloperSection for enabling developer options and submitting PR IDs. - Introduced PrivacySection for managing analytics and haptic feedback settings. - Built StorageSection to manage downloaded tracks and auto-download preferences. - Implemented PlaybackSection for streaming quality and audio normalization settings. - Added ActionChip component for interactive settings options. - Created UserProfileHeader to display user and server information.
… parallel execution
…es, Playback, Privacy, and About
- Resolved conflicts in ios/Gemfile.lock, button.tsx, component.tsx, and storage-management/index.tsx - Kept vertical settings redesign as the primary settings UI - Updated appearance screen to include color preset selection - Integrated color presets feature from main (purple, ocean, forest, sunset, peanut) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add new Account screen with profile, library, and server info - Make profile header tappable to navigate to Account screen - Fix swipe action icon consistency (use playlist-plus for AddToPlaylist) - Remove orphaned old tab components (preferences, playback, usage, account, info, labs, gestures tabs) - Remove unused section components (about, appearance, developer, gestures, playback, privacy, storage sections) - Remove old settings tab-bar and settings-list-group - Clean up sections/index.ts exports
Member
|
@skalthoff can you drop some screenshots on this PR? Otherwise I will at some point 🙂 I'm thinking this is going to come nice after nitro player, where there will be a lot more settings we can add (equalizer, etc.) |
Collaborator
Author
|
i think that's a perfect plan, this is ready to go but not needed yet, i'll add some screen shots |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change
Complete overhaul of the Settings UI with a new vertical navigation layout:
What does this address
Improves settings discoverability and organization. The previous tabbed layout was cramped and hard to navigate. The new vertical layout provides a cleaner, more intuitive experience similar to native iOS/Android settings.
Issue number / link
N/A
Tag reviewers
@anultravioletaurora