Update Scala to 3.8.1 #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update the JVM version used to run tests to 25. I was hoping we will be able to get rid of `-J--sun-misc-unsafe-memory-access=allow` but unfortunately nope, that piece of code is compiled by scalac and injected into dependency JARs... so we will have to wait for the next Scala LTS. See: scala/scala3#24109 (comment)
Member
Author
|
niegrzybkowski
approved these changes
Jan 23, 2026
Comment on lines
+24
to
+30
| // If using dependencies on Scala <3.8 and JDK >=24, we need to allow unsafe memory access. | ||
| // Otherwise, we get annoying warnings on startup. | ||
| // https://github.com/scala/scala3/issues/9013 | ||
| // Remove this after dependency upgrades to Scala 3.8+ | ||
| // See this thread for an explanation of why this requires also updates in dependencies: | ||
| // https://github.com/scala/scala3/pull/24109#issuecomment-3786629196 | ||
| "-J--sun-misc-unsafe-memory-access=allow", |
Contributor
There was a problem hiding this comment.
Some day we will be free of the sun misc unsafe memory access...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update the JVM version used to run tests to 25.
I was hoping we will be able to get rid of
-J--sun-misc-unsafe-memory-access=allowbut unfortunately nope, that piece of code is compiled by scalac and injected into dependency JARs... so we will have to wait for the next Scala LTS.See: scala/scala3#24109 (comment)