fix(tui): stabilize now via useMemo to prevent non-deterministic re-renders#714
Merged
JeremyDev87 merged 1 commit intomasterfrom Mar 19, 2026
Merged
Conversation
…enders - Replace Date.now() in render body with useMemo(() => Date.now(), [tick]) - Add test verifying now stays stable across non-tick re-renders Closes #698
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Date.now()inDashboardApprender body withuseMemo(() => Date.now(), [tick])to stabilizenowacross non-tick re-rendersnowstays consistent whentickhasn't changedTest plan
memoizes now based on tick to avoid non-deterministic re-rendersCloses #698