fix(tui): correct computeThroughput timestamp unit from ms to seconds#728
Open
JeremyDev87 wants to merge 1 commit intomasterfrom
Open
fix(tui): correct computeThroughput timestamp unit from ms to seconds#728JeremyDev87 wants to merge 1 commit intomasterfrom
JeremyDev87 wants to merge 1 commit intomasterfrom
Conversation
ActivitySample.timestamp is stored in seconds by the reducer (use-dashboard-state.ts:236), but computeThroughput divided by 60000 assuming milliseconds — causing throughput to display 1000x too high. - Change divisor from 60000 to 60 in computeThroughput - Update test data to use second-based timestamps (60000→60, 30000→30) - Add reverse-order timestamp guard test Closes #697
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
computeThroughputdividing by60000(milliseconds) instead of60(seconds), causing throughput to display 1000x too highActivitySample.timestampis stored in seconds by the reducer (use-dashboard-state.ts:236), butcomputeThroughputassumed millisecondsTest plan
live.pure.spec.tspass5.0/mininstead of5000.0/min)Closes #697