fix: equipment crash on old saves and music lifecycle#27
Merged
JesseRWeigel merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
- Guard p.equipment access with fallback to empty object, fixing "Cannot read properties of undefined (reading 'weapon')" crash when loading saves from before equipment system was added - Play combat music when entering a gate - Resume ambient music when dismissing combat results - Start ambient music 2s after game loads Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JesseRWeigel
had a problem deploying
to
github-pages
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
p.equipment.weaponcrashes when old save data lacksequipmentfield. Added|| {}guard.Test plan
🤖 Generated with Claude Code