Skip to content

TIN-1758 harden macOS rollout readiness checks#489

Open
Jesssullivan wants to merge 2 commits into
mainfrom
codex/tin1758-rollout-readiness-launchd-redaction-20260605
Open

TIN-1758 harden macOS rollout readiness checks#489
Jesssullivan wants to merge 2 commits into
mainfrom
codex/tin1758-rollout-readiness-launchd-redaction-20260605

Conversation

@Jesssullivan

@Jesssullivan Jesssullivan commented Jun 5, 2026

Copy link
Copy Markdown
Owner

Summary

Harden the macOS TCFS rollout readiness helper after the Neo switch exposed two readiness gaps:

  • Home Manager's wrapped LaunchAgent command can include too much path metadata if printed directly.
  • A single FileProvider extension ID is not enough; PlugInKit can point the extension at a rejected shadow app while the accepted package app still exists.

Changes

  • stop printing ProgramArguments:2 from the TCFS LaunchAgent
  • report only argv0 and mark launch command inspection as redacted
  • replace launchctl print gui/... with the summary launchctl list table for the service-present check
  • default --app-path to /Applications/TCFSProvider.app
  • verify the PlugInKit registration points at the expected app path, not just that the extension ID exists
  • extend the fake-platform regression test to prove both command redaction and shadow-registration detection

Test plan

  • task test passes locally
  • task lazy:test-macos-tcfs-rollout-readiness
  • bash -n scripts/macos-tcfs-rollout-readiness.sh scripts/test-macos-tcfs-rollout-readiness.sh
  • shellcheck scripts/macos-tcfs-rollout-readiness.sh scripts/test-macos-tcfs-rollout-readiness.sh
  • git diff --check
  • live Neo readiness run before cleanup failed on PlugInKit path mismatch while Gatekeeper accepted /Applications/TCFSProvider.app
  • live Neo readiness run after cleanup passed with Gatekeeper accepted, PlugInKit path matching /Applications/TCFSProvider.app, storage ok, and NATS connected

Checklist

  • Docs updated (if user-facing behavior changed)
  • CHANGELOG.md updated (if applicable)
  • No secrets or credentials in diff

Linear: TIN-1758

@Jesssullivan Jesssullivan changed the title TIN-1758 redact launchd readiness output TIN-1758 harden macOS rollout readiness checks Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant