TIN-1758 harden macOS rollout readiness checks#489
Open
Jesssullivan wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden the macOS TCFS rollout readiness helper after the Neo switch exposed two readiness gaps:
Changes
ProgramArguments:2from the TCFS LaunchAgentlaunchctl print gui/...with the summarylaunchctl listtable for the service-present check--app-pathto/Applications/TCFSProvider.appTest plan
task testpasses locallytask lazy:test-macos-tcfs-rollout-readinessbash -n scripts/macos-tcfs-rollout-readiness.sh scripts/test-macos-tcfs-rollout-readiness.shshellcheck scripts/macos-tcfs-rollout-readiness.sh scripts/test-macos-tcfs-rollout-readiness.shgit diff --check/Applications/TCFSProvider.app/Applications/TCFSProvider.app, storage ok, and NATS connectedChecklist
Linear: TIN-1758