feat: prototype editor asset library (NES-1614)#9102
Draft
edmonday wants to merge 6 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
View your CI Pipeline Execution ↗ for commit 07d4d09
☁️ Nx Cloud last updated this comment at |
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
…e picker Surface CloudflareImage history per source tab so previously uploaded and AI-generated images can be re-picked. Backed by the existing getMyCloudflareImages query in api-media. Sidesteps the Block.src overwrite issue documented in the plan pivot. Also: ignore .worktrees in git and nx project graph.
Adds a nullable isAi boolean to CloudflareImage so the editor's image picker can split user uploads from AI generations into separate grids. - New isAi column on CloudflareImage (nullable). Existing 38k rows stay NULL and are excluded from both grids. Upload and URL mutations set isAi: false; the AI-prompt mutation sets isAi: true. No backfill — we can't reliably guess which existing rows were AI-generated. - getMyCloudflareImages takes an optional isAi: Boolean arg to filter. The resolver shape (offset, limit) and return type ([CloudflareImage!]!) are unchanged — additive, non-breaking. - Editor: MyCloudflareImagesGrid renders a 3x3 grid with Load More. Custom tab shows isAi: false; AI tab shows isAi: true. Refetch on upload/AI generation surfaces new images at the top.
…m-to-select preview Surfaces a user's previously uploaded Mux videos in the editor's video upload tab so creators can re-pick a previous upload instead of re-uploading. Clicking a tile opens VideoDetails with a Select button to confirm — the in-flight upload is no longer silently cancelled by an accidental gallery click. - New MyMuxVideosGrid component (offset/limit pagination, Load More via length-equals-PAGE_SIZE heuristic). Mounted under AddByFile in VideoFromMux. - getMyMuxVideos resolver: keeps original [MuxVideo!]! shape and offset/limit args, adds deterministic orderBy [createdAt desc, id desc] required for reliable offset pagination. Filtering for ready-to-stream videos lives on the frontend, keeping the API generic. - MuxDetails: accepts optional id + playbackId, renders a Select button only when activeVideoBlock is null (gallery mode). Threading playbackId through VideoDetails avoids a redundant fetch since the gallery already has it. Cleanup also calls dispose() on the video.js player so a later preview can attach to the same playbackId without DOM-race errors. - VideoLibrary.onSelect closes the outer drawer when shouldCloseDrawer is true, so picking the same video as the active block still navigates back to Properties. - MuxVideoUploadProvider refetches GetMyMuxVideos after polling completes so freshly-ready uploads appear in the gallery. - getMyCloudflareImages: revert from Connection to keep [CloudflareImage!]! with offset/limit/isAi args (additive only, non-breaking). Apollo cache uses offsetLimitPagination(['isAi']). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
edmonday
force-pushed
the
04-28-ES-feat-editor-asset-library-personal
branch
from
b090e65 to
07d4d09
Compare
Contributor
|
The latest updates on your projects.
|
Contributor
|
Found 1 test failure on Blacksmith runners: Failure
|
Adds a 2026-05-01 dated section documenting what shipped in PR #9102 (per-tab history grids for Custom uploads, AI generations, and Mux uploads — personal scope only) and laying out v1.1 for team-shared visibility. v1.1 highlights: - Additive optional teamId arg on getMyMuxVideos and getMyCloudflareImages. - Direct Prisma cross-domain lookup (api-media imports prisma-journeys) for membership precheck and teammate userId list. Same precedent already used by the user-delete flow. - No schema/migration changes to MuxVideo or CloudflareImage. Team affiliation is computed dynamically from current UserTeam rows. - Account deletion verified: preserves media assets, deleted users auto-vanish from team galleries via the userId IN (...) filter. Also flags the rejected Connection-style refactor (prototyped + reverted) so it doesn't get re-introduced. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Frame the plan as chronologically layered; mark Enhancement Summary onward as historical context for the rejected Relay-connection / imageBlocksConnection design. - Drop quick-start (Template Customization) flow from scope per Lyuba's feedback; revisit later if needed. - Add Production rollout section: gate the three grid mount points (Custom tab, AI tab, VideoFromMux) behind the mediaLibrary LaunchDarkly flag. isAi writes and orderBy correctness changes remain ungated. - Note that v1.1 team-shared grids inherit the same flag.
Revise the v1.1 team-shared visibility section to persist a home team on each CloudflareImage / MuxVideo at upload time (derived from journey.teamId), instead of computing visibility from current UserTeam membership. Why: assets now stay with their team after the uploader leaves, and don't follow the uploader into a new team. Changes: - Add nullable teamId column + index to both models. - Upload mutations gain a journeyId arg and write teamId from journey.teamId after the existing journey-edit auth check. - Read path simplifies: 'Team uploads' filters on assets.teamId; drops the cross-domain teammate-list fetch. - Existing 38k+ rows stay NULL teamId — invisible to all team grids, visible only to original uploader's personal grid. - Membership precheck retained for the read path. - Tests, edge cases, performance, and risk sections updated to match.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes NES-1614.
Summary
Surfaces a user's previously uploaded and AI-generated images directly inside the editor's image picker, and previously uploaded Mux videos inside the editor's video picker, so creators can re-pick assets they've already produced instead of re-uploading or re-prompting.
Three grids appear in the existing tabs:
Unsplash and the YouTube / shared video library are unaffected. There is no standalone "Library" tab.
Approach
The original plan's
Block-table-as-source-of-truth approach was abandoned during prototyping after discoveringBlock.srcis overwritten in place byimageBlockUpdate(so it can't carry history). Pivot documented in the plan file.The implemented approach uses the existing per-asset tables (already independent of
Block, persisting across replacements) as the backing data:Images (
CloudflareImage)isAiboolean column onCloudflareImage. Populated by mutations going forward; existing 38k rows stayNULL(no backfill, no assumptions). Custom tab queriesisAi: false, AI tab queriesisAi: true.getMyCloudflareImagesrefactored from offset/limit flat-array into a PothosprismaConnectionwith(first, after, isAi)args — Relay cursor pagination.fetchMorewith a "Load More" button (PAGE_SIZE = 9). Apollo cache usesrelayStylePagination(['isAi']).refetchQueries: ['GetMyCloudflareImages']. WithrelayStylePagination's default merge, refetch resets the cache to the first page so the new image appears at the top.Videos (
MuxVideo)getMyMuxVideosrefactored from offset/limit flat-array into a PothosprismaConnectionwith(first, after)args — Relay cursor pagination. Filtered to user-owned videos that arereadyToStream: truewith non-nullplaybackId, so only selectable thumbnails appear.fetchMorewith a "Load More" button (PAGE_SIZE = 9). Apollo cache usesrelayStylePagination().MuxVideoUploadProvidercallsclient.refetchQueries({ include: ['GetMyMuxVideos'] })from the polling-completion path, so a freshly uploaded video appears at the top of the grid as soon as it's playable.Behavior trade-offs (intentional, prototype-grade)
CloudflareImagerows areNULL-tagged and invisible in both grids. Clean slate from now on. No backfill since we can't reliably guess which were AI-generated.readyToStream.Files of interest
apis/api-media/src/schema/cloudflare/image/image.ts— connection resolver,isAiset in upload/URL/AI mutations.apis/api-media/src/schema/mux/video/video.ts—getMyMuxVideosconnection resolver.libs/prisma/media/db/schema.prisma—CloudflareImage.isAicolumn.apps/journeys-admin/src/components/Editor/Slider/Settings/Drawer/ImageBlockEditor/MyCloudflareImagesGrid/— image grid component.apps/journeys-admin/src/components/Editor/Slider/Settings/Drawer/VideoLibrary/VideoFromMux/MyMuxVideosGrid/— Mux video grid component.apps/journeys-admin/src/components/MuxVideoUploadProvider/MuxVideoUploadProvider.tsx— refetchesGetMyMuxVideosafter polling completes.apps/journeys-admin/src/libs/apolloClient/cache.ts—relayStylePaginationpolicies.docs/plans/2026-04-28-001-feat-editor-asset-library-plan.md— plan with the approach pivot at top.Testing
apis/api-media/src/schema/cloudflare/image/image.spec.tsupdated to cover the image connection shape andisAifilter.apis/api-media/src/schema/mux/video/video.spec.tsupdated to cover the Mux connection shape and the user /readyToStream/playbackIdfilter.api-mediaandjourneys-admin.getMyCloudflareImagesandgetMyMuxVideosboth changed return type from[T!]!to a Connection. Internal grep shows no callers in this monorepo (only the resolvers, their specs, and auto-generated types — confirmed across JesusFilm/core and JesusFilm/forge forgetMyCloudflareImages), but both fields are federated through api-gateway and could have external consumers (mobile, partner integrations) that aren't visible here.Please request review from @MichaelAllisonJF (original author of
getMyCloudflareImages, PR #1301) before merging to confirm zero external blast radius. Same caution applies togetMyMuxVideos.Post-Deploy Monitoring & Validation
getMyCloudflareImagesorgetMyMuxVideosqueries withoffset/limitargs (would indicate an external consumer was relying on the old shape).Out of scope
NULLCloudflareImagerows (not done; flagged for future).nx generate-graphql api-mediais broken pre-existing (circular import); api-media schema regen worked via direct invocation. Worth a separate ticket.🤖 Generated with Claude Code