chore: videoprogresseventcreate modern#9133
Draft
mikeallisonJS wants to merge 29 commits into
Draft
Conversation
… and update access control
…connect Prevents cross-team association by verifying the journeyCollection belongs to the custom domain's team before connecting. Also distinguishes null (disconnect) from undefined (no change). Made-with: Cursor
…and permissions - Implement tests to verify behavior when journeyCollectionId is null, ensuring proper disconnection. - Add validation for journeyCollectionId ownership, returning FORBIDDEN if it belongs to another team. - Ensure correct calls to the database mock for journeyCollection queries.
- Updated the GraphQL schema to include the `customDomainCheck` mutation in both `api-gateway` and `api-journeys-modern`. - Introduced new types for `CustomDomainCheck`, `CustomDomainVerification`, and `CustomDomainVerificationResponse` in `api-journeys-modern`. - Implemented logic to verify domain configuration and verification status through Vercel API. - Ensured proper integration of the new mutation and types across relevant files.
…ourneys - Deleted custom domain related types, mutations, and queries from the GraphQL schema in `api-journeys`. - Removed associated resolver, service, and ACL files for custom domains. - Updated the app module to exclude the CustomDomainModule. - Cleaned up related tests and access control logic to streamline the codebase.
…chema - Removed override references for custom domain types and mutations in `api-journeys-modern` and `api-gateway`. - Updated the GraphQL schema to ensure consistency across custom domain functionalities. - Cleaned up related query and mutation files to align with the new schema structure.
… schema - Deleted `ChatButtonCreateInput` and `ChatButtonUpdateInput` types from the GraphQL schema. - Removed associated `chatButtonCreate` and `chatButtonUpdate` mutations from the resolver and schema. - Cleaned up related tests to reflect the removal of chat button creation and update functionalities.
- Changed the `chatButtonRemove` mutation in `api-gateway` to use the `API_JOURNEYS_MODERN` graph. - Added the `chatButtonRemove` mutation in `api-journeys-modern` with an override from `api-journeys`. - Updated the import structure in the chatButton schema to include the new mutation.
…hore-chatbutton-cleanup
- Moved `chatButtonCreate`, `chatButtonUpdate`, and `chatButtonRemove` mutations to the `api-gateway` schema under `API_JOURNEYS_MODERN`. - Updated `ChatButtonCreateInput` and `ChatButtonUpdateInput` types to be specific to `API_JOURNEYS_MODERN`. - Removed the `chatButtonRemove` mutation from the `api-journeys` schema and its resolver, along with associated tests. - Cleaned up the import structure in the journey module to reflect these changes.
…tions - Eliminated the `override` attribute for `chatButtonCreate`, `chatButtonRemove`, and `chatButtonUpdate` mutations in both `api-gateway` and `api-journeys-modern` schemas. - Updated the GraphQL schema to streamline chat button functionalities and ensure consistency across the codebase.
…r modern API - Changed the `journeyViewEventCreate` mutation in `api-gateway` to use the `API_JOURNEYS_MODERN` graph with an override reference. - Added the `journeyViewEventCreate` mutation to `api-journeys-modern` with an override from `api-journeys`. - Updated import structure in the journey module to include the new mutation file.
…rn API - Changed the `stepViewEventCreate` mutation in `api-gateway` to use the `API_JOURNEYS_MODERN` graph with an override reference. - Added the `stepViewEventCreate` mutation to `api-journeys-modern` with an override from `api-journeys`. - Updated import structure in the step module to include the new mutation file.
…modern API - Changed the `videoStartEventCreate` mutation in `api-gateway` to use the `API_JOURNEYS_MODERN` graph with an override reference. - Added the `videoStartEventCreate` mutation to `api-journeys-modern` with an override from `api-journeys`. - Updated import structure in the video module to include the new mutation file.
…dern API - Changed the `videoPlayEventCreate` mutation in `api-gateway` to use the `API_JOURNEYS_MODERN` graph with an override reference. - Added the `videoPlayEventCreate` mutation to `api-journeys-modern` with an override from `api-journeys`. - Updated import structure in the video module to include the new mutation file.
…modern API - Changed the `videoPauseEventCreate` mutation in `api-gateway` to use the `API_JOURNEYS_MODERN` graph with an override reference. - Added the `videoPauseEventCreate` mutation to `api-journeys-modern` with an override from `api-journeys`. - Updated import structure in the video module to include the new mutation file.
…n for modern API - Changed the `videoCompleteEventCreate` mutation in `api-gateway` to use the `API_JOURNEYS_MODERN` graph with an override reference. - Added the `videoCompleteEventCreate` mutation to `api-journeys-modern` with an override from `api-journeys`. - Updated import structure in the video module to include the new mutation file.
…r modern API - Changed the `videoExpandEventCreate` mutation in `api-gateway` to use the `API_JOURNEYS_MODERN` graph with an override reference. - Added the `videoExpandEventCreate` mutation to `api-journeys-modern` with an override from `api-journeys`. - Updated import structure in the video module to include the new mutation file.
…n for modern API - Changed the `videoCollapseEventCreate` mutation in `api-gateway` to use the `API_JOURNEYS_MODERN` graph with an override reference. - Added the `videoCollapseEventCreate` mutation to `api-journeys-modern` with an override from `api-journeys`. - Updated import structure in the video module to include the new mutation file.
…n for modern API - Changed the `videoProgressEventCreate` mutation in `api-gateway` to use the `API_JOURNEYS_MODERN` graph with an override reference. - Added the `videoProgressEventCreate` mutation to `api-journeys-modern` with an override from `api-journeys`. - Updated import structure in the video module to include the new mutation file.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.