feat(videos-admin): add 60-char limit and counter to video title field#9214
feat(videos-admin): add 60-char limit and counter to video title field#9214tanflem wants to merge 3 commits into
Conversation
WalkthroughAdds a 60-character maximum to the video title: Yup schema max(60) with error message, TextField enforces ChangesTitle Character Limit Feature
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit f7df345
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit c54df64
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@apps/videos-admin/src/app/`(dashboard)/videos/[videoId]/_VideoInformation/VideoInformation.spec.tsx:
- Around line 399-410: The test currently simulates typing past the UI cap by
changing titleInput to a 61-char string, but the component uses maxLength={60}
so that user action can't produce this; update the spec to exercise a
user-reachable over-limit scenario instead: render the component (or the form
field wrapper) with an initial/server-provided title exceeding 60 characters or
mock the validation/schema error path so the field shows "Title must be 60
characters or less" and verify the counter is hidden; look for references to
titleInput, the Title field render, and any props like
defaultValue/initialValues or validation handlers in VideoInformation (or its
form wrapper) to inject the over-limit value or validation error.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: a56a740e-993b-4abf-99f7-86c36a98e009
📒 Files selected for processing (2)
apps/videos-admin/src/app/(dashboard)/videos/[videoId]/_VideoInformation/VideoInformation.spec.tsxapps/videos-admin/src/app/(dashboard)/videos/[videoId]/_VideoInformation/VideoInformation.tsx
|
The latest updates on your projects.
|
…add-character-count-limit-for-titles
Summary by CodeRabbit
New Features
Tests