feat: watch watch page not loading properly by tanflem · Pull Request #9241 · JesusFilm/core

tanflem · 2026-05-21T15:26:38Z

Summary by CodeRabbit

New Features
- Added French translations for video collections and UI elements
- Added English translations for Video Bible collection area
Improvements
- Enhanced image optimization for local watch app resources
- Improved carousel behavior with language-specific video selection support

linear · 2026-05-21T15:26:43Z

coderabbitai · 2026-05-21T15:27:01Z

Warning

Rate limit exceeded

@tanflem has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 46 minutes and 21 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 69e0a8a9-fa4c-4f23-8e9a-5b544e166ad4

📥 Commits

Reviewing files that changed from the base of the PR and between 6159835 and 40aadd7.

📒 Files selected for processing (2)

apps/watch/proxy.spec.ts
apps/watch/proxy.ts

Walkthrough

The PR refactors the watch app to thread languageId through component and hook layers, enabling explicit language selection alongside locale-based fallback. Proxy middleware now centralizes /watch path rewriting with dedicated helpers for static-asset skipping and localized URL construction. CollectionsRail components are internationalized using translation hooks, with supporting locale data added for English and French.

Changes

Watch App Localization and languageId Support

Layer / File(s)	Summary
Proxy middleware and image configuration `apps/watch/next.config.js`, `apps/watch/proxy.ts`, `apps/watch/proxy.spec.ts`	Next.js image config now recognizes `/watch/images/**` as a local pattern. Proxy middleware introduces `WATCH_BASE_PATH` constant, `shouldSkipRewrite()` helper to skip internal `/watch/_next`, `/watch/api`, and static asset paths, and `getLocalizedWatchPath()` helper to construct `/watch/{locale}/...` URLs. Tests verify rewrite behavior under different locales and confirm static assets and API routes are not rewritten.
Hook chain for languageId support `apps/watch/src/components/VideoHero/libs/useCarouselVideos/useCarouselVideos.ts`, `apps/watch/src/components/VideoHero/libs/useCarouselVideos/useCarouselVideos.spec.tsx`, `apps/watch/src/components/PageMain/useWatchHeroCarousel.ts`, `apps/watch/src/components/PageMain/useWatchHeroCarousel.spec.tsx`, `apps/watch/src/components/PageMain/PageMain.tsx`	`useCarouselVideos` signature updated to accept `options` (locale string or object with `{ locale?, languageId? }`) instead of only locale, with internal resolver that prefers explicit `languageId` over locale-based resolution. `useWatchHeroCarousel` adds optional `languageId` field to options and passes both `locale` and `languageId` to `useCarouselVideos`. `PageMain` updated to pass `languageId` prop through the chain. Tests verify both locale-based fallback behavior and explicit languageId bypassing the locale resolver.
CollectionsRail localization `apps/watch/src/components/PageMain/CollectionsRail/CollectionsRail.tsx`, `apps/watch/src/components/PageMain/CollectionsRail/CollectionsRail.spec.tsx`	`CollectionsRail` now calls `useTranslation('apps-watch')` and replaces hardcoded English subtitle, title, and description overrides with `t(...)` calls across `SectionVideoCarousel` and `SectionVideoGrid` components. Test mocks translations and verifies translated content is applied and `languageId` is propagated to rail containers.
Localization strings `libs/locales/en/apps-watch.json`, `libs/locales/fr-FR/apps-watch.json`	Added English and French translation strings for Video Bible collections, Christmas Advent series, course descriptions, language selection UI, playback controls, and navigation labels.

🎯 3 (Moderate) | ⏱️ ~22 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title is vague and does not clearly communicate the main purpose of the changes, using generic phrasing like 'not loading properly' without specifying what was fixed or implemented.	Revise the title to be more specific and descriptive of the actual changes, such as 'feat: add languageId support to carousel and update locale data' or similar.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch tannerfleming/qa-475-watch-watch-page-not-loading-properly

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-05-21T15:27:51Z

View your CI Pipeline Execution ↗ for commit 6159835

Command	Status	Duration	Result
`nx run journeys-e2e:e2e`	✅ Succeeded	26s	View ↗
`nx run journeys-admin-e2e:e2e`	✅ Succeeded	28s	View ↗
`nx run watch-e2e:e2e`	✅ Succeeded	16s	View ↗
`nx run resources-e2e:e2e`	✅ Succeeded	11s	View ↗
`nx run watch-modern-e2e:e2e`	✅ Succeeded	3s	View ↗
`nx run player-e2e:e2e`	✅ Succeeded	3s	View ↗
`nx run videos-admin-e2e:e2e`	✅ Succeeded	3s	View ↗
`nx run-many --target=vercel-alias --projects=watch`	✅ Succeeded	1s	View ↗
`Additional runs (20)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2026-05-21 16:49:27 UTC

github-actions · 2026-05-21T15:29:50Z