fix(admin): remove Algolia and stale bucket references#910
Open
tataihono wants to merge 1 commit into
Open
Conversation
|
🚅 Deployed to the forge-pr-910 environment in forge
2 services not affected by this PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Admin no longer carries the throwaway Algolia parity path in the keyword search canary. The route now compares only admin's hybrid and keyword-first GraphQL search modes, and the removed code takes the
ALGOLIA_*env contract with it.The admin storage docs and helper comments now keep
RAILWAY_S3_*as the Railway S3 contract without naming or defaulting to CMS or manager bucket resources. Manager artifact reads still useMANAGER_ARTIFACTS_S3_*, so the storage split remains explicit without pointing operators at another bucket value.What Changed
ALGOLIA_*validation from admin env config.Verification
pnpm --filter @forge/admin typecheckpnpm --filter @forge/admin lintpnpm --filter @forge/admin test -- src/app/watch/demo-keyword-search/diff.test.ts src/scripts/pull-mapping-from-prod.test.ts src/scripts/refresh-core-id-mapping.import-isolation.test.ts src/services/core-id-mapping.service.test.ts src/storage/s3.s3-backend.test.ts src/storage/s3.prod-guard.test.ts src/storage/s3.manager-artifacts-backend.test.ts src/storage/s3.manager-artifacts-prod-guard.test.tsgit diff --check