feat(manager): gate Agentic Studio access#917
Open
lumberman wants to merge 3 commits into
Open
Conversation
|
🚅 Deployed to the forge-pr-917 environment in forge
5 services not affected by this PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Manager-gated access to Agentic Studio without exposing the Studio service as a public app. Manager now owns
/dashboard/agentic-studioand/api/agentic-studio/[[...path]], verifies Manager sessions, requires theManagerrole, strips browser auth/forwarding headers, injectsAGENTIC_OPERATOR_API_KEYserver-side, and fails closed when Studio proxy config is missing.The proxy also hardens the embedded Studio path: private production origins are restricted to
agentic-studio.railway.internal, HTML/JSON/JS responses are rewritten away from internal/public Agentic origins, upstream redirects are safely rewritten, upstream cookies are dropped, authenticated responses areprivate, no-store, and Studio frame subrequests use a short-lived signed frame token instead of exposing the operator key.What changed
AGENTIC_STUDIO_ORIGINandAGENTIC_OPERATOR_API_KEY.agentic-studioservice and no-public-domain deployment model.feat-121for deeper browser-enforced Studio frame isolation hardening.Validation
pnpm --filter @forge/manager test -- src/config/env.test.ts src/lib/agentic-studio-proxy.test.ts src/lib/agentic-automation-dry-run.test.ts src/lib/agentic-subtitle-enrichment.test.ts 'src/app/api/agentic-studio/[[...path]]/route.test.ts' src/app/dashboard/agentic-studio/page.test.tspnpm --filter @forge/manager typecheckpnpm --filter @forge/manager lintpnpm --filter @forge/manager buildpnpm --filter @forge/agentic testpnpm --filter @forge/agentic typecheckpnpm --filter @forge/agentic lintpnpm --filter @forge/agentic buildgit diff --checkBrowser smoke
Using
agent-browseragainst local Manager mock mode and a fake private Studio upstream:/dashboard/agentic-studioredirected to/login./dashboard/agentic-studio./api/agentic-studio.AGENTIC_OPERATOR_API_KEY.Local screenshot evidence:
output/playwright/manager-agentic-studio-smoke.png.🤖 Generated with Compound Engineering