Merge Jetpack Lifecycle 2.11.0-alpha01#2795
Conversation
eymar
force-pushed
the
integration-copy/lifecycle/f6a3829acf1/to-jb-main
branch
from
d226266 to
36b65f1
Compare
|
Note: k/wasm tests failed with I don't want to bump Kotlin version here. I already bumped it in #2790 We can't rebase this branch. So I'd suggest to "mark pipeline as green" and proceed with merging. |
| import androidx.lifecycle.ViewModelStoreOwner | ||
|
|
||
| public actual val ViewModelStoreOwnerHostDefaultKey: HostDefaultKey<ViewModelStoreOwner?> = | ||
| object : HostDefaultKey<ViewModelStoreOwner?> {} |
There was a problem hiding this comment.
What's the reason for splitting non-android to desktop and non-jvm here? it looks the same
There was a problem hiding this comment.
| api("org.jetbrains.compose.runtime:runtime:1.8.2") | ||
| api("org.jetbrains.compose.runtime:runtime-saveable:1.8.2") | ||
| api("org.jetbrains.compose.runtime:runtime:1.11.0-alpha03") | ||
| api("org.jetbrains.compose.runtime:runtime-saveable:1.11.0-alpha03") |
There was a problem hiding this comment.
Any reason to do it? Seems incorrect
There was a problem hiding this comment.
They use new API from compose runtime. So it's expected that the latest compose runtime is needed.
They use project dependency. Since we pin versions here, I decided to pin too.
There was a problem hiding this comment.
There are no changes in code aside from build.gralde. I don't understand what changes you're talking about.
In general, for such cases we should unpin as well
There was a problem hiding this comment.
This is a change in navigation 2 library, not lifecycle
There was a problem hiding this comment.
just for history: this change has been removed>
The new runtime is need necessary for lifecycle. We unpinned and changed to project dependency.
It requires a newer compose-runtime
eymar
force-pushed
the
integration-copy/lifecycle/f6a3829acf1/to-jb-main
branch
from
100cf47 to
5a1019f
Compare
2 participants
Fixes https://youtrack.jetbrains.com/issue/CMP-9805/Merge-Jetpack-Compose-1.11.0-alpha06
Testing
N/A
Release Notes
N/A