Support sizing of UIKit interop views using Auto Layout#2797
Open
Support sizing of UIKit interop views using Auto Layout#2797
Conversation
…ement logic for interop views
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for sizing of UIKit interop views using Auto Layout.
Introduces
UIKitInteropElementLayoutuserComponentview into hierarchyUIKitInteropElementMeasurerMeasurePolicyfor the Compose node hosting the UIKit interop viewuserComponentfitting size and providing it to Compose layoutUIKitInteropRemeasureRequesterUIKitInteropRemeasureRequesterUIKitInteropPropertiesUIKitVieworUIKitViewControllerbased on fitting size changes of the given interopViewFixes CMP-9123 iOS support intrinsic sizing of interop elements - UIView with NSLayoutConstraints
Testing
Adds iOS instrumented tests covering interop view behavior:
UIKitInteropRemeasureRequester(constraint constant change, text change)remeasureRequesterlifecycle (binding/unbinding when interop node is added/removed)This should be tested by QA
Release Notes
Features - iOS
remeasureRequesterAPI toUIKitInteropProperties. UseUIKitInteropRemeasureRequester.requestRemeasure()to request re-measurement ofUIKitVieworUIKitViewControllerrememberUIKitInteropRemeasureRequester()API