other method to add compatible DS4 usb devices#36
Open
ozzyyzzo4096 wants to merge 1 commit intoJibbSmart:masterfrom
Open
other method to add compatible DS4 usb devices#36ozzyyzzo4096 wants to merge 1 commit intoJibbSmart:masterfrom
ozzyyzzo4096 wants to merge 1 commit intoJibbSmart:masterfrom
Conversation
Owner
|
Hi Ozzy, thanks for your PR. We can't use product IDs as unique indices. If I have two official DualShock 4 connected, they'll both have the same product ID. The reason I use product IDs and not the product name is because I don't know if other products using a similar name will actually report with the same structure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rather than expecting and comparing or list or individual product IDs , just accept all product IDs and use them as a unique indices aswell.