Skip to content

Fix dex2oat wrapper SELinux check on Android 14+ #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pbzin wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −1
Open

Fix dex2oat wrapper SELinux check on Android 14+ #785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion daemon/src/main/kotlin/org/matrix/vector/daemon/env/Dex2OatServer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,23 @@ object Dex2OatServer {
"u:r:untrusted_app:s0", "u:object_r:dex2oat_exec:s0", "file", "execute_no_trans")
}

/**
* Android 14 moved dex2oat invocation behind artd. artd is allowed to
* transition through dex2oat_exec, while the old dex2oat domain used the
* execute_no_trans check. Checking the old tuple on Android 14+ falsely
* selects the xposed_file fallback and leaves artd unable to execute the
* bind-mounted wrapper.
*/
private fun canUseDex2OatExec(): Boolean {
return if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {
SELinux.checkSELinuxAccess(
"u:r:artd:s0", "u:object_r:dex2oat_exec:s0", "file", "execute")
} else {
SELinux.checkSELinuxAccess(
"u:r:dex2oat:s0", "u:object_r:dex2oat_exec:s0", "file", "execute_no_trans")
}
}

private fun openDex2oat(id: Int, path: String) {
runCatching {
fdArray[id] = Os.open(path, OsConstants.O_RDONLY, 0)
Expand Down Expand Up @@ -207,7 +224,7 @@ object Dex2OatServer {
val xposedFile = "u:object_r:xposed_file:s0"
val dex2oatExec = "u:object_r:dex2oat_exec:s0"

if (SELinux.checkSELinuxAccess("u:r:dex2oat:s0", dex2oatExec, "file", "execute_no_trans")) {
if (canUseDex2OatExec()) {
SELinux.setFileContext(WRAPPER32, dex2oatExec)
SELinux.setFileContext(WRAPPER64, dex2oatExec)
setSockCreateContext("u:r:dex2oat:s0")
Expand Down