feat: add comprehensive test coverage for Book and Category entities by JlusS · Pull Request #14 · JlusS/LiteraSphere-API

JlusS · 2025-09-13T00:21:05Z

Added unit tests for BookRepository and CategoryRepository
Implemented service layer tests for BookService and CategoryService
Added controller tests for BookController and CategoryController with security mocking
Achieved over 50% test coverage for targeted classes
Included test coverage screenshot in PR description
Configured test environment with H2 database and security mocks
Added necessary test dependencies and configuration files

Tests cover:

CRUD operations for both Book and Category entities
Security constraints and role-based access control
Pagination and search functionality
Validation and error handling scenarios

- Implemented service layer tests for BookService and CategoryService - Added controller tests for BookController and CategoryController with security mocking - Achieved over 50% test coverage for targeted classes - Included test coverage screenshot in PR description - Configured test environment with H2 database and security mocks - Added necessary test dependencies and configuration files Tests cover: - CRUD operations for both Book and Category entities - Security constraints and role-based access control - Pagination and search functionality - Validation and error handling scenarios

Elena-Bruyako

apply comments for all tests

Elena-Bruyako · 2025-09-15T10:19:42Z

+        // Given
+        BookDto bookDto = createBookDto();
+        Page<BookDto> page = new PageImpl<>(List.of(bookDto));
+        when(bookService.findAll(any(Pageable.class))).thenReturn(page);


don't mock data for integration tests
fix other places

Elena-Bruyako · 2025-09-15T10:19:52Z

+
+        String responseContent = result.getResponse().getContentAsString();
+
+        Assertions.assertTrue(responseContent.contains("Test Book"));


use static imports for all places

Elena-Bruyako · 2025-09-15T10:20:15Z

+        Assertions.assertTrue(responseContent.contains("Test Author"));
+        Assertions.assertTrue(responseContent.contains("29.99"));
+
+        Assertions.assertTrue(responseContent.contains("\"title\":\"Test Book\""));


compare objects or content
don't compare by fields
same comment for all places

Elena-Bruyako · 2025-09-15T10:20:49Z

+        book.setPrice(requestDto.getPrice());
+        book.setIsbn(requestDto.getIsbn());
+
+        Category category1 = new Category();


never use numbers for naming

Elena-Bruyako · 2025-09-15T10:21:20Z

+            and return the corresponding BookDto with correct category IDs
+            """)
+    void save_withValidRequest_returnsBookDtoWithCategoryIds() {
+        CreateBookRequestDto requestDto = new CreateBookRequestDto();


create TestUtil class and initialise all test data there
don't forget to put this class in util package

Elena-Bruyako · 2025-09-15T10:22:33Z

+
+        BookDto actualDto = bookService.save(requestDto);
+        Assertions.assertEquals(expectedDto, actualDto);
+    }


add verify() for all unit test methods

Elena-Bruyako

see comments

Elena-Bruyako · 2025-09-16T10:30:54Z

+    @DisplayName("Get all books")
+    void findAll_WithUserRole_ShouldReturnPageOfBooks() throws Exception {
+        // Given
+        Category categoryProgramming = categoryRepository.save(createProgrammingCategory());


use sql scripts to insert test data into database

Elena-Bruyako · 2025-09-16T10:31:28Z

+        );
+
+        assertThat(books).hasSize(1);
+        assertThat(books.get(0).getTitle()).isEqualTo("Effective Java");


compare content

Elena-Bruyako · 2025-09-16T10:31:56Z

+                BookDto.class
+        );
+        assertNotNull(actual);
+        assertEquals(savedBook.getTitle(), actual.getTitle());


compare objects actual and expected
not by fields

Elena-Bruyako · 2025-09-16T10:32:14Z

+        assertNotNull(actual);
+        assertEquals(requestDto.getTitle(), actual.getTitle());
+        assertEquals(requestDto.getAuthor(), actual.getAuthor());
+        assertEquals(1, bookRepository.count());


Elena-Bruyako · 2025-09-16T10:33:48Z

+        assertNotNull(books);
+        assertEquals(1, books.length);
+        assertEquals(book.getTitle(), books[0].getTitle());
+    }


add not valid test cases
compare content or expected and actual objects
don't compare by fields

Elena-Bruyako · 2025-09-16T10:34:38Z

+@Transactional
+@Testcontainers


Why do you need

@Transactional @Testcontainers

Elena-Bruyako · 2025-09-16T10:34:47Z

+
+        List<Book> actual = bookRepository.findAllByCategories_Id(savedCategory.getId());
+
+        Assertions.assertEquals(1, actual.size());


use static import

Elena-Bruyako · 2025-09-16T10:39:38Z

+import org.springframework.test.web.servlet.MvcResult;
+
+@SpringBootTest
+@AutoConfigureMockMvc


Suggested change

@AutoConfigureMockMvc

Elena-Bruyako · 2025-09-16T10:39:49Z

+
+@SpringBootTest
+@AutoConfigureMockMvc
+@ActiveProfiles("test")


Why do you need profiles here?

Elena-Bruyako · 2025-09-16T10:39:52Z

@@ -1,9 +1,6 @@
-spring.datasource.url=jdbc:h2:mem:testdb
-spring.datasource.driverClassName=org.h2.Driver
+spring.datasource.url=jdbc:tc:mysql:8.0.37:///mydb


Why do you need profiles?

JlusS added 2 commits September 13, 2025 02:20

fixed-checkstyle

8723d0f

Elena-Bruyako suggested changes Sep 15, 2025

View reviewed changes

fixed

d1a1027

Elena-Bruyako suggested changes Sep 16, 2025

View reviewed changes

fixed

7804c70

JlusS requested a review from Elena-Bruyako September 16, 2025 14:48

Elena-Bruyako approved these changes Sep 17, 2025

View reviewed changes

JlusS merged commit 022b525 into master Sep 17, 2025
2 checks passed

JlusS deleted the HW branch September 17, 2025 14:23


		String responseContent = result.getResponse().getContentAsString();

		Assertions.assertTrue(responseContent.contains("Test Book"));


		List<Book> actual = bookRepository.findAllByCategories_Id(savedCategory.getId());

		Assertions.assertEquals(1, actual.size());

		@Transactional
		@Testcontainers

Conversation

JlusS commented Sep 13, 2025

Uh oh!

Elena-Bruyako left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Elena-Bruyako left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants