Replace literal keyword or with || operator in FileModule.cpp#15
Open
MineRobber9000 wants to merge 1 commit into
Open
Replace literal keyword or with || operator in FileModule.cpp#15MineRobber9000 wants to merge 1 commit into
MineRobber9000 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC doesn't really like the literal keyword operators, and it seemed kind of dumb to include
<iso646.h>when it's only used in these 8 spots here (there are some compiler flags you can toss at MSVC to make it work, but those require disabling MSVC's permissive mode which causes a bunch of other stuff to break).