Switch agent structured contracts from JSON to XML tags; add XML builder and tests#48
Open
JohnEsleyer wants to merge 3 commits intomainfrom
Open
Switch agent structured contracts from JSON to XML tags; add XML builder and tests#48JohnEsleyer wants to merge 3 commits intomainfrom
JohnEsleyer wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
system_prompt.txtanddocs/DOCKER_CUBICLES.mdto use XML-tagged contracts (<thought>,<message>,<terminal>,<action>) instead of JSON envelopes.dashboard/src/public/index.htmlto request XML-tagged contract output from agents.shell/src/xml-contract.tsimplementingbuildXmlContractwith entity escaping and imported it intoshell/src/server.tsto produce XML contracts in assistant history and to markcontractFormatasxml.shell/src/server.tsthat parses and logs XML contracts using existing parsing utilities.shell/tests/xml-contract.test.tsforbuildXmlContractbehavior andshell/tests/system-prompt-contract.test.tsto assert the system prompt no longer contains JSON examples and includes the XML tags.Testing
vitestand the new testsxml-contract.test.tsandsystem-prompt-contract.test.tspassed.buildXmlContractoutputs are detected asxmlbydetectContractFormatand are safely escaped by the tests.system_prompt.txtand docs are covered by the contract-format test and did not introduce test regressions.Codex Task