feat(web): QR code on the setup funding step#267
Merged
Merged
Conversation
Funding from a wallet on another device was scan-nothing, retype- everything. The setup funding card now shows the same uppercase-bech32 QR the dashboard's Add Bitcoin card renders, in both single-heir and group mode. Last shipped item from the UX review's page-by-page pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setup funding step showed only a text address; funding from a phone wallet meant retyping. It now renders the same scannable QR the dashboard's Add Bitcoin card uses (uppercase bech32 for a sparser code), in both single-heir and multi-heir group mode.
Last shipped item from the UX review's page-by-page pass (after #262, #264, #265, #266). Remaining review scope is only the Pidgin interactive-claim translation, tracked in #204.
Checks: tsc clean, 58 web tests, eslint clean, vite build ok.
🤖 Generated with Claude Code