fix(web): no false testnet banner when API is down + Show password toggle#269
Merged
Conversation
…ggle Desktop review findings: - AlphaBanner rendered whenever /health had *completed*, including failures. `network` defaults to "testnet", so a mainnet owner whose server was briefly unreachable saw "Alpha: GhostKey is running on Bitcoin testnet. Don't use real-money keys yet" - false and alarming at the worst moment. Banner now renders only when /health succeeds; ServerOfflineBanner already covers the failure case. - Sign-in password field gets a Show/Hide toggle. Mistyped passwords are the top sign-in failure and the field hid every character. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two findings from the desktop review pass (1440px, all public pages screenshotted from a production build):
False testnet warning on mainnet. The alpha banner rendered once the /health probe completed, including failures, and the network state defaults to "testnet". So any API blip made the live mainnet site announce "running on Bitcoin testnet. Don't use real-money keys yet." Now the banner only renders when /health succeeds; the offline banner covers the rest. Verified by screenshot with the API unreachable: only the honest offline banner shows.
Show password toggle on sign-in. The field hid every character with no way to check; password UX is money UX here since the password unseals the vault key.
Checks: tsc clean, 58 web tests, eslint clean, vite build ok.
🤖 Generated with Claude Code