Tuned defaults to significant values#1
Open
gsspdev wants to merge 2 commits into
Open
Conversation
❌ Deploy Preview for algorust failed.
|
gsspdev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tuned default frequencies to 55hz and 880hz, A notes in ISO 16 standard tuning. The default input_len has also been changed to 96. Factors of 12 are useful when mapping pitch as their are 12 tones in a standard octave. Factors of 32 are useful when dealing with algorithms and computation. 96 is the least common multiple of these two integers. If the pitches are subdivided evenly along the log scale, the resulting subdivisions of the four octave range from 55hz to 880hz and 96 corresponds perfectly to the chromatic notes from A1-A5 in just intonation. There may be more work to be done.