CI: replace bogus Compile-and-Release with real Windows tests#13
Merged
Conversation
The old build-and-release.yml g++-compiled Magisk.cpp (deleted, so it always failed) and, on tag push, ran a release step that would clobber hand-cut releases with nonexistent magisk.exe / NewblueStacksRoot.cmd. Replace it with .github/workflows/tests.yml (push/PR to main + manual): runs tests/Run-Tests.ps1 and tests/Run-Resolve-Tests.ps1 on windows-latest via 'powershell -File' (Windows PowerShell 5.1, exactly as the .cmd does), and a new tests/Check-Embedded-Sync.ps1 that fails if the engine/orchestrator embedded in blueStackRoot.cmd drift from tools\bsr_engine.ps1 / tools\bsr_magisk.ps1. No compiling, no releasing.
On CI $env:TEMP is the 8.3 short form (C:\Users\RUNNER~1\...); the engine resolves the on-disk Root.vhd and returns the long path, so the exact-string VHD assertion mismatched purely on short-vs-long. Expand the fake DataDir root to its long form (GetLongPathName) at creation so all expected paths match what the engine returns. No product change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The old
.github/workflows/build-and-release.yml("Compile and Release") was bogus and a latent hazard:g++-compiledMagisk.cpp, which was deleted from the repo — so every run failed at the compile step.tags: '*'push it then ran asoftprops/action-gh-releasestep that would have overwritten the release name/body and uploaded a nonexistentmagisk.exe/NewblueStacksRoot.cmd. (It only ever spared the releases because it died at compile first.)Instead
A focused, genuinely useful
tests.ymlthat runs on push/PR tomain(+ manual), onwindows-latest, invoking each suite viapowershell -File— the same Windows PowerShell 5.1 the.cmduses:tests/Check-Embedded-Sync.ps1(new) — fails if the engine/orchestrator embedded inblueStackRoot.cmddrift fromtools/bsr_engine.ps1/tools/bsr_magisk.ps1(the single-file build's NOT WORKING #1 silent failure mode — forgettingtools/reembed.ps1).tests/Run-Tests.ps1— engine: integrity patch,.bstkdisk-mode, conf root flags, su round-trip, bootstrap (28).tests/Run-Resolve-Tests.ps1— nothing-hardcoded + adb-port resolution (22).No compiling, no auto-releasing — releases are cut by hand. All three pass locally (exit 0); the ext4/debugfs tier in Run-Tests auto-skips on CI (no
mke2fs).