Open
Conversation
parallels a change made for topic editor to have substeps use letters instead of numbers.
Contributor
Author
|
this is for parity with topic editor. |
Contributor
|
shouldn't this be lower-alpha(a, b, c)? |
Contributor
Author
|
lower roman accomplishes the same thing |
Collaborator
|
This looks fine to me as long as @rkaron has no issues since I know he's been doing a lot of work on this recently as well. |
Contributor
|
isn't lower-roman (i, i, iii)? |
Contributor
Author
|
sorry, yes, it should be lower-alpha to match the topic editor. |
change lower-roman to lower-alpha. we want a, b, c, not i, ii, iii
Contributor
|
Hey, from my POV it should be lower-alpha. I expect to deploy "my" template to GitHub by the end of September. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parallels a change made for topic editor to have substeps use letters instead of numbers.