Open
Conversation
added 9 commits
July 2, 2024 10:53
Not happy about the on-call import for EMBEDDED_MESSAGE
As per comment, I'm unsure if this is just how UNICODE values are stored, or if there is a off-by-one error (off by two since it's utf16?) somewhere.
Owner
|
Thanks. I like the ideas. But I can't accept changes that i can't easily review. The reorganization shows up on GitHub as large deletes and large insertions, so I can't see if anything changed. I'd be happy to review if the reorganization is removed and left for another time. |
Author
|
I did break them into individual commits so you don't have to try to evaluate the whole PR as one change. But, I respect that it's hard to approve changes without unit tests to give confidence. I made an alternative PR #30 if this is too overwhelming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having trouble getting this to convert the msg files released by Microsoft related to the disclosure of the Midnight Blizzard attack. So, I went down a troubleshooting rabbit hole. The core issue was overlooking HTML bodies.