Upgrading Julia LTS version to 1.10 in CI job#164
Open
pebeto wants to merge 9 commits intoJuliaAI:devfrom
Open
Upgrading Julia LTS version to 1.10 in CI job#164pebeto wants to merge 9 commits intoJuliaAI:devfrom
1.10 in CI job#164pebeto wants to merge 9 commits intoJuliaAI:devfrom
Conversation
DilumAluthge
reviewed
Nov 6, 2025
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
Member
|
You might also need to upgrade to a newer Documenter.jl version (https://github.com/pebeto/MLJLinearModels.jl/blob/6b282650d3eb1504de51f43a44725ebea86c15be/docs/Project.toml#L5 might be too old for Julia 1.10). |
ablaom
reviewed
Nov 6, 2025
| ŷ = MLJBase.mode.(ŷ) | ||
|
|
||
| mcr = MLJBase.misclassification_rate(ŷ, yc) | ||
| mcr = MLJ.misclassification_rate(ŷ, yc) |
Member
There was a problem hiding this comment.
I doubt you really need MLJ here. The metrics used to be defined in MLJBase, but now they are provided by StatisticalMeasures.jl
ablaom
reviewed
Nov 6, 2025
test/Project.toml
Outdated
| @@ -14,13 +14,3 @@ RDatasets = "ce6b1742-4840-55fa-b093-852dadbb1d8b" | |||
| Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c" | |||
| StableRNGs = "860ef19b-820b-49d6-a774-d7a799459cd3" | |||
Member
There was a problem hiding this comment.
In my experience, having a separate test/Project.toml is problematic when deving several packages locally, and I moved away from this. Can we get rid of it altogether? Maybe this even fixes your LTS fail.
Member
|
Thanks for jumping in with some maintanence here @pebeto. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading the LTS version is something already mentioned in JuliaAI/MLJ.jl#1143.