Skip to content

Define is_commutative function interface #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blegat merged 2 commits into from
Mar 31, 2026
Merged

Define is_commutative function interface #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec8a51c
Define `is_commutative` function interface
claude Mar 29, 2026
d6ad5c7
Fixes
blegat Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/src/types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ isrealpart
isimagpart
isconj
ordinary_variable
is_commutative
```

## Monomials
Expand Down
11 changes: 11 additions & 0 deletions src/variable.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,17 @@ This operation is not type stable for the TypedPolynomials implementation if `nv
"""
variable(t::_APL) = convert(variable_union_type(t), t)

"""
is_commutative(::Type{<:AbstractVariable})::Bool

Returns whether variables of the given type are commutative, i.e., whether
`x * y == y * x`.
"""
function is_commutative end
is_commutative(p::_APL) = is_commutative(typeof(p))
is_commutative(v::AbstractVector) = is_commutative(eltype(v))
is_commutative(v::Tuple) = all(is_commutative, v)

"""
name(v::AbstractVariable)::AbstractString

Expand Down
Loading