Skip to content

Declare global names as const #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daanhb merged 2 commits into from
Jun 17, 2026
Merged

Declare global names as const #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3de0847
Declare `×` as a `const`
jishnub Jun 8, 2026
8244b74
Declare other global names as `const`
jishnub Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/domains/trivial.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
struct EmptySpace{T} <: Domain{T}
end

EmptySet = EmptySpace
const EmptySet = EmptySpace

const AnyEmptySpace = EmptySpace{Any}

Expand Down
2 changes: 1 addition & 1 deletion src/generic/interface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ DomainStyle(::Type{<:Number}) = IsDomain()
DomainStyle(::Type{<:AbstractSet}) = IsDomain()
DomainStyle(::Type{<:AbstractArray}) = IsDomain()

BaseDomainType = Union{<:Number,<:AbstractSet,<:AbstractArray}
const BaseDomainType = Union{<:Number,<:AbstractSet,<:AbstractArray}

"""
domain(d)
Expand Down
6 changes: 3 additions & 3 deletions src/generic/productdomain.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ closure(d::ProductDomain) = ProductDomain(map(closure, components(d)))

center(d::ProductDomain) = toexternalpoint(d, map(center, components(d)))

VcatDomainElement = Union{Domain{<:Number},EuclideanDomain}
VcatEltype = Union{Type{<:Number},Type{<:StaticVector}}
const VcatDomainElement = Union{Domain{<:Number},EuclideanDomain}
const VcatEltype = Union{Type{<:Number},Type{<:StaticVector}}

"""
ProductDomain(domains...)
Expand Down Expand Up @@ -133,7 +133,7 @@ Alias for [`cartesianproduct`](@ref). Note that this differs from LinearAlgebra.
!!! note
`×` requires at least v0.8.0 of DomainSets.jl.
"""
× = cartesianproduct
const × = cartesianproduct

Base.:^(d::Domain, n::Int) = productdomain(ntuple(i->d, n)...)

Expand Down
Loading