Fully qualify constructor extension

[jpthiele]

Extending constructors without module specification can lead to undefined behaviour in case of name clashes. This is fixed by fully qualifying ArrayInterface.BandedMatrixIndex when it is extended in the banded matrix ext.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.71%. Comparing base (9e3936c) to head (9d38d86).
Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   62.71%   62.71%           
=======================================
  Files          12       12           
  Lines         574      574           
=======================================
  Hits          360      360           
  Misses        214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ChrisRackauckas]

Thanks! It would be good to test this better but it's such an edge case to hit.

[jpthiele]

Thanks! It would be good to test this better but it's such an edge case to hit.

Is there a reasonable way to catch and save warnings thrown by a function call without interrupting/stopping it?
If yes I could add something to DownstreamTester since Pkg.add() already throws these warnings in nightly.

[ChrisRackauckas]

catch and save warnings thrown by a function call without interrupting/stopping it?

Modify the warn logger or redirect stderr?