Eigen for FillArrays#330
Open
jishnub wants to merge 5 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 8 8
Lines 1147 1171 +24
=======================================
+ Hits 1146 1170 +24
Misses 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
This (and other parts that depend on LinearAlgebra.jl) should probably be an extension? Though I guess that can wait |
Member
Author
|
Yes, we should move these to an extension eventually. Presumably, |
Member
Author
|
Should we proceed? |
Member
Author
|
Gentle bump |
1 similar comment
Member
Author
|
Gentle bump |
Member
Author
|
Bump |
Member
Author
|
Gentle bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase #256 with only the
FillArraypart implemented this time. This makeseigvalsO(1) andeigenO(N^2)