Skip to content

Update RectDiagonal broadcasting to accept 2-element size#424

Merged
dlfivefifty merged 1 commit into
masterfrom
jishnub/rectdiagonal_bcast
Jan 6, 2026
Merged

Update RectDiagonal broadcasting to accept 2-element size#424
dlfivefifty merged 1 commit into
masterfrom
jishnub/rectdiagonal_bcast

Conversation

@jishnub

@jishnub jishnub commented Dec 17, 2025

Copy link
Copy Markdown
Member

LinearAlgebra now passes the 2-element size of the matrix to structured_broadcast_alloc. This adapts the method in this package to accept the 2-term size. This would be backward compatible, as minimum is a no-op for a number.

The change here gets tests working on julia v1.14.

@codecov

codecov Bot commented Dec 17, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.82%. Comparing base (0a58cd8) to head (9296b5a).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #424       +/-   ##
===========================================
+ Coverage    0.00%   99.82%   +99.82%     
===========================================
  Files           8        8               
  Lines        1152     1156        +4     
===========================================
+ Hits            0     1154     +1154     
+ Misses       1152        2     -1150     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dlfivefifty

Copy link
Copy Markdown
Member

can you add a test that fails without this change?

@jishnub

jishnub commented Dec 20, 2025

Copy link
Copy Markdown
Member Author

Tests already exist and are failing on v1.13 alpha. The CI failures on the master branch currently should be resolved by this change.

@jishnub

jishnub commented Dec 25, 2025

Copy link
Copy Markdown
Member Author

Good to merge?

@jishnub

jishnub commented Jan 5, 2026

Copy link
Copy Markdown
Member Author

Gentle bump

@dlfivefifty dlfivefifty merged commit 3e305a8 into master Jan 6, 2026
28 checks passed
@dlfivefifty dlfivefifty deleted the jishnub/rectdiagonal_bcast branch January 6, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants