feat: refactor Client to support multiple HTTP libraries #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a way to choose between different HTTP libraries while instantiating an OpenAPI client. Maintains OpenAPI API and models compatibility, though the HTTP library specific return values (raw response, errors and such) would be as per the chosen library.
- New HTTP client library abstraction: Created an interface contract for HTTP client libraries (`httplibs.jl`, `julialang_downloads.jl`, `juliaweb_http.jl`)
- Modularized client code: Moved client types and chunk readers into dedicated modules (`clienttypes.jl`, `chunk_readers.jl`)
- Client libraries support:
- Default: Downloads.jl
- Optional: HTTP.jl via new `httplib` parameter
Enables future backend additions without major refactoring. Maintains backward compatibility (Downloads.jl is default).
Example:
```julia
client = Client("http://api.example.com")
client = Client("http://api.example.com"; httplib=OpenAPI.HTTPLib.HTTP)
api = MyGeneratedApi(client)
result, http_resp = get_resource(api, 123)
@info "Status: $(http_resp.status)"
@info "Headers: $(http_resp.headers)"
raw_response = http_resp.raw # HTTP.Response or Downloads.Response
```
Useful to compare different http client libraries
Member
Author
|
I seems ready to me... can merge in some time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a way to choose between different HTTP libraries while instantiating an OpenAPI client. Maintains OpenAPI API and models compatibility, though the HTTP library specific return values (raw response, errors and such) would be as per the chosen library.
httplibs.jl,julialang_downloads.jl,juliaweb_http.jl)clienttypes.jl,chunk_readers.jl)httplibparameterEnables future backend additions without major refactoring. Maintains backward compatibility (Downloads.jl is default).
Example: